bharatviswa504 commented on a change in pull request #9: HDDS-2240. Command 
line tool for OM Admin
URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r337278663
 
 

 ##########
 File path: 
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
 ##########
 @@ -223,6 +226,20 @@ public RpcClient(Configuration conf, String omServiceId) 
throws IOException {
         OzoneConfigKeys.OZONE_NETWORK_TOPOLOGY_AWARE_READ_DEFAULT);
   }
 
+  @Override
+  public List<OMRoleInfo> getOmRoleInfos() throws IOException {
 
 Review comment:
   If some user call's this API after a period of time the information in 
OMRoleInfo might be stale. If we expose here, I think we should contact OM and 
get this info again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to