lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS
pipeline creation and destroy through heartbeat commands
URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r338650934
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestBlockManager.java
##########
@@ -245,7 +252,7 @@ public void testAllocateBlockSucInSafeMode() throws
Exception {
GenericTestUtils.waitFor(() -> {
return !blockManager.isScmInSafeMode();
}, 10, 1000 * 5);
- Assert.assertNotNull(blockManager.allocateBlock(DEFAULT_BLOCK_SIZE,
+ Assert.assertNull(blockManager.allocateBlock(DEFAULT_BLOCK_SIZE,
Review comment:
Similar to testBlockAllocationWithNoAvailablePipelines, I think
allocateBlock should not return null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
