bharatviswa504 commented on a change in pull request #40: HDDS-2285. GetBlock and ReadChunk command from the client should be s… URL: https://github.com/apache/hadoop-ozone/pull/40#discussion_r338868517
########## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java ########## @@ -107,6 +111,7 @@ public XceiverClientGrpc(Pipeline pipeline, Configuration config, OzoneConfigKeys.OZONE_NETWORK_TOPOLOGY_AWARE_READ_KEY, OzoneConfigKeys.OZONE_NETWORK_TOPOLOGY_AWARE_READ_DEFAULT); this.caCert = caCert; + this.getBlockDNcache = new HashMap<>(); Review comment: XceiverClientGrpc is shared across threads, do we need to make this ConcurrentHashMap? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org