fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis
getFactor and getType from XCeiverClientManager
URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340234544
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
##########
@@ -180,7 +181,7 @@ private void testRpcPermissionWithConf(
try {
ContainerWithPipeline container2 = mockClientServer
- .allocateContainer(xceiverClientManager.getType(),
+ .allocateContainer(SCMTestUtils.getReplicationType(ozoneConf),
HddsProtos.ReplicationFactor.ONE, "OZONE");
Review comment:
This magic constant is used in multiple tests, I would suggest to resolve
this in a separate JIRA after this one get merged, I have created
https://issues.apache.org/jira/browse/HDDS-2378 to track this, and I am open to
post a patch for that as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
