arp7 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush
termination and OM shutdown's after that. Make entry returned from cache a new
copy.
URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340312109
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -288,7 +289,17 @@ public Builder setKeyName(String key) {
public Builder setOmKeyLocationInfos(
List<OmKeyLocationInfoGroup> omKeyLocationInfoList) {
- this.omKeyLocationInfoGroups = omKeyLocationInfoList;
+ if (omKeyLocationInfoList != null) {
Review comment:
Why can this be null? Is it straightforward to replace null with
`Collections.emptyList()` in caller? Generally good to avoid nulls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
