ChenSammi commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-548642429 > > > Thanks for working on this @ChenSammi, I cannot understand the changes, How does moving the createIfNeccessary function fixes the issue ? Hi @mukul1987 , because some of MetadataStoreBuilder caller want the createIfMissing to be true, and some want it to be false. Current implementaion caches the first "org.rocksdb.Options" instance for each configuration. Every next time caller gets the same createIfMissing, it's self createIfMissing input is ignored. For this "fail to crate Ratis container" case, first time createIfMissing is "false", which will not create the directory for new containers, so the creation failed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
