Thanks. I have reverted HDFS-15624, committed HDFS-15666, and posted a PR for HDFS-15624.
On Fri, Apr 23, 2021 at 1:59 PM Akira Ajisaka <aajis...@apache.org> wrote: > Hi Wei-Chiu and Brahma, > > +1 for the proposal. > > Normally we expect the NameNode layout version is the same between > bugfix releases. However, HDFS-15566 is a serious issue. Therefore I > think we can bump the layout version even in the bugfix release if the > new layout version is required to fix the issue. > > Thanks, > Akira > > On Fri, Apr 23, 2021 at 12:40 PM Wei-Chiu Chuang <weic...@apache.org> > wrote: > > > > Hello I want to discuss this with the wider community. > > > > In HDFS-15624 (fix the function of setting quota by storage type), A new > > layout version was added > > NVDIMM_SUPPORT(-66, -61, "Support NVDIMM storage type"); > > This was added for 3.4.0 (trunk) > > > > However, there's another jira > > HDFS-15566 (NN restart fails after RollingUpgrade from 3.1.3/3.2.1 to > 3.3.0) > > SNAPSHOT_MODIFICATION_TIME(-66, -61, "Support modification time for > > snapshot"); > > > > where Brahma wanted to add a new layout version in branch-3.3 (3.3.1). > The > > patch got stalled awhile ago and I'm trying to commit it in preparation > of > > 3.3.1 release. > > > > However, both new layout versions conflict because they intend to use the > > new same version id. We can't release 3.3.1 without HDFS-15566 but we > can't > > use layout id -66 because of HDFS-15624. > > > > I propose: > > revert HDFS-15624 (NVDIMM_SUPPORT), > > commit HDFS-15566 (SNAPSHOT_MODIFICATION_TIME) > > re-work on HDFS-15624 but with layout version id -67 > > > > Thoughts? > > Wei-Chiu >
