[ https://issues.apache.org/jira/browse/HDFS-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akira Ajisaka resolved HDFS-16151. ---------------------------------- Fix Version/s: 3.3.2 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Committed to trunk and branch-3.3. Thank you [~jianghuazhu] for your contribution. > Improve the parameter comments related to ProtobufRpcEngine2#Server() > --------------------------------------------------------------------- > > Key: HDFS-16151 > URL: https://issues.apache.org/jira/browse/HDFS-16151 > Project: Hadoop HDFS > Issue Type: Bug > Components: documentation > Reporter: JiangHua Zhu > Assignee: JiangHua Zhu > Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.3.2 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Now missing some parameter comments related to ProtobufRpcEngine2#Server(), > as follows: > /** > * Construct an RPC server. > * > * @param protocolClass the class of protocol > * @param protocolImpl the protocolImpl whose methods will be called > * @param conf the configuration to use > * @param bindAddress the address to bind on to listen for connection > * @param port the port to listen for connections on > * @param numHandlers the number of method handler threads to run > * @param verbose whether each call should be logged > * @param portRangeConfig A config parameter that can be used to restrict > * the range of ports used when port is 0 (an ephemeral port) > * @param alignmentContext provides server state info on client responses > */ > public Server(Class<?> protocolClass, Object protocolImpl, > Configuration conf, String bindAddress, int port, int numHandlers, > int numReaders, int queueSizePerHandler, boolean verbose, > SecretManager<? extends TokenIdentifier> secretManager, > String portRangeConfig, AlignmentContext alignmentContext) > throws IOException { > super(protocolClass, protocolImpl, conf, bindAddress, port, numHandlers, > numReaders, queueSizePerHandler, verbose, secretManager, > portRangeConfig, alignmentContext); > } > The description of numReaders, queueSizePerHandler, and secretManager is > missing here. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org