[
https://issues.apache.org/jira/browse/HDFS-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729863#action_12729863
]
Raghu Angadi commented on HDFS-397:
-----------------------------------
I am probably not the right person to review...
I assume this essentially code reorg with no changes in semantics.. looks like
one of these is not correct :
{noformat}
- editLog.divertFileStreams(STORAGE_JSPOOL_DIR + "/" + STORAGE_JSPOOL_FILE);
+ editLog.divertFileStreams()
{noformat}
{noformat}
- divertFileStreams(
- Storage.STORAGE_DIR_CURRENT + "/" + NameNodeFile.EDITS_NEW.getName());
+ divertFileStreams()
{noformat}
Am I reading the patch correctly?
Could you also point out locations in patch for HDFS-311, where this patch
matters? (line numbers in the patch would be enough). thanks.
> Incorporate storage directories into EditLogFileInput/Output streams
> --------------------------------------------------------------------
>
> Key: HDFS-397
> URL: https://issues.apache.org/jira/browse/HDFS-397
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Luca Telloli
> Assignee: Luca Telloli
> Attachments: HADOOP-6001.patch, HADOOP-6001.patch, HADOOP-6001.patch,
> HDFS-397.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
