[
https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luca Telloli updated HDFS-456:
------------------------------
Attachment: HDFS-456.patch
I run the tests on windows, using trunk + this patch and trunk + reverted 396,
to see whether failures are due to this patch or not. I fixed a couple of error
in the patch that I'm now posting.
To find some additional issues I run each test both on a directory containing
spaces in path (like c:\Documents and Settings) and a directory not containing
spaces, which apparently made the difference.
The impression is that windows builds have been neglected since some time, due
to the fact that some tests fail on both pre and post patch code.
The outcome is that the remaining failing tests (which fail only on windows)
are not related to this patch. Details follow for public discussion:
FIXED TESTS:
by modifying code:
{noformat}
Testsuite: org.apache.hadoop.hdfs.TestDFSShell
Tests run: 14, Failures: 1, Errors: 3, Time elapsed: 64.25 sec
Testsuite: org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
Tests run: 2, Failures: 1, Errors: 1, Time elapsed: 27.172 sec
{noformat}
without modifying code:
{noformat}
Testsuite: org.apache.hadoop.hdfs.TestFileAppend2
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 99.781 sec
Testsuite: org.apache.hadoop.hdfs.TestReplication
Tests run: 5, Failures: 0, Errors: 1, Time elapsed: 48.656 sec
{noformat}
FAILS ON BOTH:
if the path contains spaces (otherwise works):
{noformat}
Testsuite: org.apache.hadoop.hdfs.TestDatanodeBlockScanner
Tests run: 4, Failures: 0, Errors: 1, Time elapsed: 118.078 sec
Testsuite: org.apache.hadoop.fs.TestUrlStreamHandler
Tests run: 2, Failures: 0, Errors: 2, Time elapsed: 23.969 sec
{noformat}
other causes:
{noformat}
Testsuite: org.apache.hadoop.cli.TestHDFSCLI
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 108.047 sec
{noformat}
{noformat}
Testsuite: org.apache.hadoop.hdfs.TestHDFSTrash
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 20.171 sec
Testcase: testTrash took 1.609 sec
Testcase: testNonDefaultFS took 0.188 sec
FAILED
null
junit.framework.AssertionFailedError: null
at org.apache.hadoop.fs.TestTrash.checkTrash(TestTrash.java:62)
at org.apache.hadoop.fs.TestTrash.trashNonDefaultFS(TestTrash.java:335)
at org.apache.hadoop.hdfs.TestHDFSTrash.testNonDefaultFS(TestHDFSTrash.j
ava:61)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.extensions.TestSetup.run(TestSetup.java:27)
{noformat}
{noformat}
Testsuite: org.apache.hadoop.hdfs.TestHDFSServerPorts
Tests run: 4, Failures: 4, Errors: 0, Time elapsed: 7.437 sec
Testcase: testNameNodePorts took 2.906 sec
FAILED
null
junit.framework.AssertionFailedError: null
at org.apache.hadoop.hdfs.TestHDFSServerPorts.testNameNodePorts(TestHDFS
ServerPorts.java:256)
Testcase: testDataNodePorts took 1.515 sec
FAILED
null
junit.framework.AssertionFailedError: null
at org.apache.hadoop.hdfs.TestHDFSServerPorts.testDataNodePorts(TestHDFS
ServerPorts.java:291)
Testcase: testSecondaryNodePorts took 0.938 sec
FAILED
null
junit.framework.AssertionFailedError: null
at org.apache.hadoop.hdfs.TestHDFSServerPorts.testSecondaryNodePorts(Tes
tHDFSServerPorts.java:319)
Testcase: testBackupNodePorts took 1.312 sec
FAILED
Backup started on same port as Namenode
junit.framework.AssertionFailedError: Backup started on same port as Namenode
at org.apache.hadoop.hdfs.TestHDFSServerPorts.testBackupNodePorts(TestHD
FSServerPorts.java:348)
{noformat}
> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
> Key: HDFS-456
> URL: https://issues.apache.org/jira/browse/HDFS-456
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Luca Telloli
> Fix For: 0.21.0
>
> Attachments: HDFS-456.patch, HDFS-456.patch, HDFS-456.patch,
> HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws
> {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an
> illegal URI. Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because
> it is a {{RuntimException}}. We should throw {{IOException}} instead. This
> was recently discussed in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is
> the minimum requirement for a patch to qualify as committable, right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
