[ 
https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732568#action_12732568
 ] 

Luca Telloli commented on HDFS-456:
-----------------------------------

To answer my own question, I run the test on trunk + HDFS-496 30 times 
consecutively, for 2 times. 
The first time it passed 12 times, and failed 18; the second time it failed 23 
times and passed 7 times. 
In the second batch I saved the test logs and they all fail for the same error 
below, which is the same error that makes the test fail with HDFS-396 reverted, 
so that I'd conclude that this patch does not impact that test. The error seems 
related to something left open, and I assume it's OS specific. 

{noformat}
Testcase: testReplicateLenMismatchedBlock took 1.984 sec
        Caused an ERROR
The requested operation cannot be performed on a file with a user-mapped section
 open
java.io.IOException: The requested operation cannot be performed on a file with 
a user-mapped section open
        at java.io.RandomAccessFile.setLength(Native Method)
        at 
org.apache.hadoop.hdfs.TestDatanodeBlockScanner.changeReplicaLength(TestDatanodeBlockScanner.java:419)
        at 
org.apache.hadoop.hdfs.TestReplication.changeBlockLen(TestReplication.java:424)
        at 
org.apache.hadoop.hdfs.TestReplication.testReplicateLenMismatchedBlock(TestReplication.java:403)
{noformat}

> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: failing-tests.zip, HDFS-456.patch, HDFS-456.patch, 
> HDFS-456.patch, HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws 
> {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an 
> illegal URI. Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because 
> it is a {{RuntimException}}. We should throw {{IOException}} instead. This 
> was recently discussed in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is 
> the minimum requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to