[
https://issues.apache.org/jira/browse/HDFS-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-525:
----------------------------------------
Component/s: name-node
Hadoop Flags: [Reviewed]
+1 patch looks good.
Some thoughts:
I appreciate the effort of adding a nice test, which is something we have to do
in order to pass the QA requirement. But (1) concurrent accessing a
non-thread-safe class is an obvious bug, (2) using a ThreadLocal variable is a
standard solution and (3) a unit test may take seconds (up to 30 seconds in the
test provided by the patch). I am not sure whether it is worthwhile to have a
new unit test in this case.
> ListPathsServlet.java uses static SimpleDateFormat that has threading issues
> ----------------------------------------------------------------------------
>
> Key: HDFS-525
> URL: https://issues.apache.org/jira/browse/HDFS-525
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-525.1.patch, HDFS-525.patch, HDFS-525.patch
>
>
> SimpleDateFormat is not thread safe. Multiple threads accessing the servlet
> can cause threading issues
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
