[
https://issues.apache.org/jira/browse/HDFS-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745578#action_12745578
]
Konstantin Boudnik commented on HDFS-555:
-----------------------------------------
- I'd suggest to introduce a literal constant for "0.0.0.0:0" and for
"127.0.0.1:0"
- {{MiniDFSCluster.java:324}} misspelled word 'hostnames'. Should be 'host
names'
- {{MiniDFSCluster.java:354}} same as above
- documentation of the method {{injectBlocks(int, Block[]}} says that the
method is only valid in a certain cases. However, it doesn't do any
verifications nor enforces any check. Either documentation or the method's
implementation has to be changed.
- {{MiniDFSCluster.java:943}} introduces new JavaDoc error because of a word's
misspelling
> A few improvements to DataNodeCluster - HADOOP-5556
> ----------------------------------------------------
>
> Key: HDFS-555
> URL: https://issues.apache.org/jira/browse/HDFS-555
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Ravi Phulari
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: HDFS-555.patch
>
>
> Opening jira to address HDFS code changes made in HADOOP-5556.
> DataNodeCluster is a great tool to simulate a large scale DFS cluster using a
> small set of machines. A few suggestions to improve this tool:
> 1. DataNodeCluster uses MiniDFSCluster#startDataNode to start multiple
> instances of DataNode on one machine. MiniDFSCluster sets DataNode's address
> to be 127.0.0.1. We should allow to set its address to 0.0.0.0 so DataNodes
> in different machines could communicate.
> 2. Currently the size of the blocks injected to DataNode and created in
> CreatedEditsLog is hardcoded as 10. It would be more convenient if this could
> be configurable. Also we need to make sure that both use the same block size.
> 3. If the replication factor of blocks is larger than 1, currently a
> DataNode in DataNodeCluster will be injected blocks multiple times and
> therefore it sends block reports to NameNode multiple times. Initial block
> reports contain only a portion of its blocks and therefore may cause
> unnecessary block replications. It would be cleaner if only one block report
> with all its blocks is sent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
