[
https://issues.apache.org/jira/browse/HDFS-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750595#action_12750595
]
Tsz Wo (Nicholas), SZE commented on HDFS-581:
---------------------------------------------
{quote}
ClientDatanodeProtocol
2. JavaDoc for getReplicaVisibleLength() is confusing. Could you please also
make it 3 lines rather than 1.
{quote}
Why 3 lines?
{quote}
LocatedBlock
3. Does not need any of the changes.
{quote}
Could you explain more?
{quote}
LocatedBlocks
4. Here you do multiple field and method renames, combined with reformatting. I
am lost.
{quote}
How can I help you?
{quote}
FSDatasetInterface
5. Why do you need to abstract getReplicaInfo()? It does not seem that
SimulatedFSDataset actually need it anywhere, at least not yet.
{quote}
FSDatasetInterface is an *interface*. By definition, all methods in an
interface must be abstract.
{quote}
BlockManager
6. You factored out a part of the code into a new method. I cannot see what the
new changes are.
{quote}
The new method is involved in FSNamesystem. Could you take a look again?
{quote}
INodeFile
8. It is not necessary to remove public from method declaration and remove
unused method.
{quote}
I remove the method because I see the following comment in the code.
{code}
// SHV !!! this is not used anywhere - remove
{code}
The comment was introduced by you in HDFS-517. Could you explain what does it
mean?
> Introduce an iterator over blocks in the block report array.
> ------------------------------------------------------------
>
> Key: HDFS-581
> URL: https://issues.apache.org/jira/browse/HDFS-581
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.20.1
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockReportIterator.patch, BlockReportIterator.patch
>
>
> A block iterator will hide the internal implementation of the block report as
> an array of three longs per block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
