[
https://issues.apache.org/jira/browse/HDFS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753182#action_12753182
]
Tsz Wo (Nicholas), SZE commented on HDFS-603:
---------------------------------------------
> Tthe two changes to ReplicasMap are necessary. For the newly introduced
> method get(Replica r), the returned reference should be the same as the input
> reference.
Yes, I will revert the changes.
> I will a sort of uneasiness when an input ref. is being simply return from a
> wrapper method. It opens all sorts of possible security issues. Shall the
> parameter, at very least, be declared as final?
Could you be more specific? Which methods you are talking about? What are the
security issues? Which parameters should be declared as final?
> Most replica related classes cannot be accessed
> -----------------------------------------------
>
> Key: HDFS-603
> URL: https://issues.apache.org/jira/browse/HDFS-603
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: Append Branch
> Reporter: Tsz Wo (Nicholas), SZE
> Fix For: Append Branch
>
> Attachments: h603_20090908.patch
>
>
> Currently, there are several replica related classes in
> org.apache.hadoop.hdfs.server.datanode:
> - ReplicaInfo
> - ReplicaInPipelineInterface
> - ReplicaInPipeline
> - ReplicaUnderRecovery
> - ReplicaWaitingToBeRecovered
> - ReplicaBeingWritten
> - FinalizedReplica
> All these classes cannot be accessed above FSDatasetInterface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
