[
https://issues.apache.org/jira/browse/HDFS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759830#action_12759830
]
Eli Collins commented on HDFS-245:
----------------------------------
Hey Dhruba,
Patch looks good, some comments:
MountPointException why extend IOException to not modify function prototypes to
declare it? Don't we want the interfaces to explicility delcare this, eg as is
done with UnresolvedPathException?
Why do we need both MountPointException (now UnresolvedLinkException) and
UnresolvedPathException?
Why does getLinkTargetImpl need to take an exception, shouldn't it call into
the NN to resolve the given path?
How can createSymlink throw DSQuotaExceededException? Seems like
createSymlinkInternal won't (since symlinks have no contents).
Agree with making maxPathLinks in range 8-32
The NN throws UnresolvedPathException even when it can resolve the link
internally, perhaps add the latter as a comment that this could be a future
optimization.
Nit, constructPath should use StringBuilder
> Create symbolic links in HDFS
> -----------------------------
>
> Key: HDFS-245
> URL: https://issues.apache.org/jira/browse/HDFS-245
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: 4044_20081030spi.java, designdocv1.txt,
> HADOOP-4044-strawman.patch, symlink-0.20.0.patch, symLink1.patch,
> symLink1.patch, symLink11.patch, symLink12.patch, symLink13.patch,
> symLink14.patch, symLink15.txt, symLink15.txt, symlink16-common.patch,
> symlink16-hdfs.patch, symlink16-mr.patch, symlink17-common.txt,
> symlink17-hdfs.txt, symLink4.patch, symLink5.patch, symLink6.patch,
> symLink8.patch, symLink9.patch
>
>
> HDFS should support symbolic links. A symbolic link is a special type of file
> that contains a reference to another file or directory in the form of an
> absolute or relative path and that affects pathname resolution. Programs
> which read or write to files named by a symbolic link will behave as if
> operating directly on the target file. However, archiving utilities can
> handle symbolic links specially and manipulate them directly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
