[
https://issues.apache.org/jira/browse/HDFS-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suresh Srinivas updated HDFS-677:
---------------------------------
Attachment: hdfs-677.9.patch
> will need extensive testing...
Currently TestHDFSCLI, TestQuota and the new test cases added add to a lot of
testcases. Let me know if you feel any thing more specific is needed. Also
FSDirectory.verifyQuota() is mostly refactored code out of
FSDirectory.updateCount().
> Check the value returned by getExistingPathINodes(), compare it with the
> number of path components.
This is what current checks for {{dstInodes[dstInodes.length-1] != null}} and
{{dstInodes[dstInodes.length-2] == null}} does. If you feel it is still good to
add additional check for return value, I can add it.
> you addChild() with inheritPermission == true. In the old code it was false.
> Is that intentional?
That was not intentional. Thanks for catching it.
Attaching new patch with incorporated comments.
> Rename failure due to quota results in deletion of src directory
> ----------------------------------------------------------------
>
> Key: HDFS-677
> URL: https://issues.apache.org/jira/browse/HDFS-677
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0, 0.22.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Blocker
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: hdfs-677.8.patch, hdfs-677.9.patch
>
>
> Renaming src to destination where src has exceeded the quota to a dst without
> sufficent quota fails. During this failure, src is deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
