[ 
https://issues.apache.org/jira/browse/HDFS-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766230#action_12766230
 ] 

Konstantin Boudnik commented on HDFS-705:
-----------------------------------------

Oops, seems like I forgot to post the results of test-patch run. Here it is
{noformat}
There appear to be 109 release audit warnings before the patch and 109 release 
audit warnings after applying the patch.

+1 overall.  
    +1 @author.  The patch does not contain any @author tags.
    +1 tests included.  The patch appears to include 3 new or modified tests.
    +1 javadoc.  The javadoc tool did not generate any warning messages.
    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.
    +1 findbugs.  The patch does not introduce any new Findbugs warnings.
    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.
{noformat}

> Create an adapter to access some of package-private methods of DataNode from 
> tests
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-705
>                 URL: https://issues.apache.org/jira/browse/HDFS-705
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.22.0
>
>         Attachments: HDFS-705.patch, HDFS-705.patch, HDFS-705.patch
>
>
> Some of tests from packages other than 
> {{org.apache.hadoop.hdfs.server.datanode}} need an access to package-private 
> methods of that package. Proposed patch will add new adapter class which will 
> have public getter methods to provide such access to outside of the package.
> This is TEST ONLY class: it never has to be used for ANY development purposes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to