[ 
https://issues.apache.org/jira/browse/HDFS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766301#action_12766301
 ] 

Konstantin Boudnik commented on HDFS-710:
-----------------------------------------

Patch looks good.

Nits: 
- public methods do not have normally required {...@param}} nor {...@throw}} 
tags. I'm not sure if it is required, but I think it's a good style to have 
them.

+1 otherwise.

> Add actions with constraints to the pipeline fault injection tests
> ------------------------------------------------------------------
>
>                 Key: HDFS-710
>                 URL: https://issues.apache.org/jira/browse/HDFS-710
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>         Attachments: h710_20091015b.patch
>
>
> It is useful to have _constraint satisfaction actions_ so that an action is 
> fired if all the constraints are satisfied.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to