[
https://issues.apache.org/jira/browse/HDFS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769333#action_12769333
]
Konstantin Boudnik commented on HDFS-584:
-----------------------------------------
I ran the build on healthy code and it went through as usual.
Then I've intentionally broke some advice bindings and started the build
{noformat}
% ant injectfaults
{noformat}
and got these effect:
{noformat}
compile-fault-inject:
[echo] Start weaving aspects in place
[iajc] warning at
/Users/cos/work/Hdfs.inj/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0
advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has
not been a
pplied [Xlint:adviceDidNotMatch]
BUILD FAILED
/Users/cos/work/Hdfs.inj/build.xml:346: The following error occurred while
executing this line:
/Users/cos/work/Hdfs.inj/build.xml:338: Broken binding of advices:
[iajc] warning at
/Users/cos/work/Hdfs.inj/src/test/aop/org/apache/hadoop/hdfs/server/datanode/FSDatasetAspects.aj:55::0
advice defined in org.apache.hadoop.hdfs.server.datanode.FSDatasetAspects has
not been a
pplied [Xlint:adviceDidNotMatch]
Total time: 37 seconds
{noformat}
> Fail the fault-inject build if any advices are mis-bound
> --------------------------------------------------------
>
> Key: HDFS-584
> URL: https://issues.apache.org/jira/browse/HDFS-584
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-584.patch
>
>
> Whenever AspectJ compiler can't bind an advice it issues a warning message,
> but the build process isn't failing because of it.
> The build has to fail though, because mis-bound advices lead to failing tests
> which are hard to explain otherwise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
