[
https://issues.apache.org/jira/browse/HDFS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787340#action_12787340
]
Hadoop QA commented on HDFS-793:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12427277/separateSendRcvAck1.patch
against trunk revision 888218.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/135/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/135/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/135/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/135/console
This message is automatically generated.
> DataNode should first receive the whole packet ack message before it
> constructs and sends its own ack message for the packet
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-793
> URL: https://issues.apache.org/jira/browse/HDFS-793
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Priority: Blocker
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: separateSendRcvAck.patch, separateSendRcvAck1.patch
>
>
> Currently BlockReceiver#PacketResponder interleaves receiving ack message and
> sending ack message for the same packet. It reads a portion of the message,
> sends a portion of its ack, and continues like this until it hits the end of
> the message. The problem is that if it gets an error receiving the ack, it is
> not able to send an ack that reflects the source of the error.
> The PacketResponder should receives the whole packet ack message first and
> then constuct and sends out its ack.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
