[
https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Shvachko updated HDFS-456:
-------------------------------------
Attachment: EditsDirsWin.patch
This patch is based on the previous patches submitted by Luca, and updated by
Jonathan.
- I removed unused testing for incorrect URI containing windows drive letters.
- Improved some message reporting and JavaDoc comments.
- Replaced storage directory declaration in {{hdfs-default.xml}} with URIs for
"dfs.namenode.name.dir" and "dfs.namenode.checkpoint.dir".
- I fixed {{MiniDFSCluster}} so that it sets URIs as storage directories not
files.
- Fixed other tests, which set or use storage directories besides the
mini-cluster.
> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
> Key: HDFS-456
> URL: https://issues.apache.org/jira/browse/HDFS-456
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: EditsDirsWin.patch, failing-tests.zip,
> HDFS-456-clean.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch,
> HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws
> {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an
> illegal URI. Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because
> it is a {{RuntimException}}. We should throw {{IOException}} instead. This
> was recently discussed in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is
> the minimum requirement for a patch to qualify as committable, right?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
