[ 
https://issues.apache.org/jira/browse/HDFS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787978#action_12787978
 ] 

dhruba borthakur commented on HDFS-724:
---------------------------------------

I am still looking at the patch, two comments:

1. Is it possible to get rid of lastDataNodeRun() completely? This method 
existed because the last datanode in the pipeline needed to send heartbeats. 
Now, thatis not needed anymore.

2. In DFSClient.java, one change is:

{quote}
                long timeout = (stage == BlockConstructionStage.DATA_STREAMING)?
                  socketTimeout/2 - (now-lastPacket) : 1000;
{quote}

timeout could sometime be negative?

> Pipeline close hangs if one of the datanode is not responsive.
> --------------------------------------------------------------
>
>                 Key: HDFS-724
>                 URL: https://issues.apache.org/jira/browse/HDFS-724
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, hdfs client
>    Affects Versions: 0.21.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: h724_20091021.patch, pipelineHeartbeat.patch
>
>
> In the new pipeline design, pipeline close is implemented by sending an 
> additional empty packet.  If one of the datanode does not response to this 
> empty packet, the pipeline hangs.  It seems that there is no timeout.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to