[ 
https://issues.apache.org/jira/browse/HDFS-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797384#action_12797384
 ] 

Chris Douglas commented on HDFS-786:
------------------------------------

Only minor nits:
* WARN may be overly aggressive for a client calling {{getContentSummary}} in a 
loop. Both it and the TRACE logger are probably unnecessary.
*  {{TestListPathServlet}} can be updated to use 
{{MiniDFSCluster::getHftpFileSystem}} in its {{setup}} method

Other than that, +1

> Implement getContentSummary(..) in HftpFileSystem
> -------------------------------------------------
>
>                 Key: HDFS-786
>                 URL: https://issues.apache.org/jira/browse/HDFS-786
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.22.0
>
>         Attachments: h786_20091223.patch, h786_20091224.patch, 
> h786_20100104.patch
>
>
> HftpFileSystem does not override getContentSummary(..).  As a result, it uses 
> FileSystem's default implementation, which computes content summary on the 
> client side by calling listStatus(..) recursively.  In contrast, 
> DistributedFileSystem has overridden getContentSummary(..) and does the 
> computation on the NameNode.
> As a result, running "fs -dus" on hftp is much slower than running it on hdfs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to