[ 
https://issues.apache.org/jira/browse/HDFS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799749#action_12799749
 ] 

Hudson commented on HDFS-145:
-----------------------------

Integrated in Hadoop-Hdfs-trunk #199 (See 
[http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/199/])
    . Cleanup inconsistent block length handling code in 
FSNameSystem#addStoredBlock. Contributed by Hairong Kuang.


> FSNameSystem#addStoredBlock does not handle inconsistent block length 
> correctly
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-145
>                 URL: https://issues.apache.org/jira/browse/HDFS-145
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: corruptionDetect.patch, corruptionDetect1.patch, 
> corruptionDetect2.patch, inconsistentLen.patch, inconsistentLen1.patch, 
> inconsistentLen2.patch
>
>
> Currently NameNode treats either the new replica or existing replicas as 
> corrupt if the new replica's length is inconsistent with NN recorded block 
> length. The correct behavior should be
> 1. For a block that is not under construction, the new replica should be 
> marked as corrupt if its length is inconsistent (no matter shorter or longer) 
> with the NN recorded block length;
> 2. For an under construction block, if the new replica's length is shorter 
> than the NN recorded block length, the new replica could be marked as 
> corrupt; if the new replica's length is longer, NN should update its recorded 
> block length. But it should not mark existing replicas as corrupt. This is 
> because NN recorded length for an under construction block does not 
> accurately match the block length on datanode disk. NN should not judge an 
> under construction replica to be corrupt by looking at the inaccurate 
> information:  its recorded block length.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to