[
https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835302#action_12835302
]
Konstantin Boudnik commented on HDFS-520:
-----------------------------------------
A couple of nits:
- {{TestBlockRecovery}} has a mix of JUnit3 and JUnit4 in it. In particular
{noformat}
+import static junit.framework.Assert.assertTrue;
{noformat}
needs to be replaced with appropriate {{org.junit}} imports
- TestLeaseRecovery2#testHardLeaseRecovery uses a mix of LOG statements and
invocations of {{System.out.println}}. Is it intentional?
- in general, would it make sense to add some test description in the form of
JavaDoc?
Looks good otherwise!
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch
>
>
> According to the test plan a number of new features are going to be
> implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of
> new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
