[
https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837060#action_12837060
]
Konstantin Shvachko commented on HDFS-988:
------------------------------------------
# {{enterSafeMode()}} looks good.
# {{FSNamesystem.getAdditionalBlock()}} checking {{isInSafeMode()}} should be
before calling {{chooseTargets()}}. I would not change {{getAdditionalBlock()}}
at all.
# I think it is fine to {{FSNamesystem.commitBlockSynchronization()}} in safe
mode. In any case it probably deserves a separate issue and discussion.
# {{renewLease()}} shouldn't be under FSNamesystem lock? {{leaseManeger}} has
its own lock.
# Your changes to permission methods incorporate HDFS-133.
# Dhruba, are you going to promote changes to trunk and 0.21?
> saveNamespace can corrupt edits log
> -----------------------------------
>
> Key: HDFS-988
> URL: https://issues.apache.org/jira/browse/HDFS-988
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: dhruba borthakur
> Attachments: saveNamespace.txt
>
>
> The adminstrator puts the namenode is safemode and then issues the
> savenamespace command. This can corrupt the edits log. The problem is that
> when the NN enters safemode, there could still be pending logSycs occuring
> from other threads. Now, the saveNamespace command, when executed, would save
> a edits log with partial writes. I have seen this happen on 0.20.
> https://issues.apache.org/jira/browse/HDFS-909?focusedCommentId=12828853&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12828853
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
