[
https://issues.apache.org/jira/browse/HDFS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837945#action_12837945
]
Eli Collins commented on HDFS-1000:
-----------------------------------
Minor comments:
* Needs additional tests, you already know that
* Need to check return values, eg cURI below. Know this is old code but good to
fix it while you're at it.
{code}
+ cURI = malloc(strlen(host)+16);
+ sprintf(cURI, "hdfs://%s:%d", host, (int)(port));
{code}
* You should be able to remove HADOOP_UNIX_USER_GROUP_INFO now
* Some lines are > 80 cols
* Can remove some of the debug statements you added, eg:
{code}
+ System.out.println("GETCURRENTUSER CALLED");
{code}
* Have you checked that this doesn't introduce additional leaks, eg by looking
at memory usage?
> libhdfs needs to be updated to use the new UGI
> ----------------------------------------------
>
> Key: HDFS-1000
> URL: https://issues.apache.org/jira/browse/HDFS-1000
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.22.0
>
> Attachments: hdfs-1000-bp20.patch
>
>
> libhdfs needs to be updated w.r.t the APIs in the new UGI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
