[ 
https://issues.apache.org/jira/browse/HDFS-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851513#action_12851513
 ] 

Suresh Srinivas commented on HDFS-955:
--------------------------------------

With the new solution, I see the following issues:
# The order in which namespace is saved is still important. It has to be image 
followed by edits. If edits is emptied first, during recovery either edits is 
lost or system will not start due to image time not matching with that of edits.
# On a failure after saving image and before edits is emptied, during recovery, 
the system may not start due to mismatch between fsimage and edits time. 
However, there is no loss of data in this case.

> FSImage.saveFSImage can lose edits
> ----------------------------------
>
>                 Key: HDFS-955
>                 URL: https://issues.apache.org/jira/browse/HDFS-955
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: FSStateTransition7.htm, hdfs-955-moretests.txt, 
> hdfs-955-unittest.txt, PurgeEditsBeforeImageSave.patch, 
> saveNamespace-0.20.patch, saveNamespace-0.21.patch, saveNamespace.patch, 
> saveNamespace.txt
>
>
> This is a continuation of a discussion from HDFS-909. The FSImage.saveFSImage 
> function (implementing dfsadmin -saveNamespace) can corrupt the NN storage 
> such that all current edits are lost.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to