[
https://issues.apache.org/jira/browse/HDFS-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855464#action_12855464
]
Suresh Srinivas commented on HDFS-1088:
---------------------------------------
There are two variants of rename implementation (one of them is deprecated).
Could you please add this check to both of them. Also please throw an exception
instead of returning false. I know that the new
FSDirectory#unprotectedRenameTo() with rename options is returning false in one
of the cases (dst.equals(src)). I think we should change that to throw an
exception as well. If you are not doing that in this patch, I will create a bug
to track that.
> Prevent renaming a symlink to it's target
> ------------------------------------------
>
> Key: HDFS-1088
> URL: https://issues.apache.org/jira/browse/HDFS-1088
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-1088-1.patch
>
>
> Here's the HDFS side of HADOOP-6563:
> * Small bug fix for renaming a symlink to it's target
> * Hdfs#getFileBlockLocations needs to use getUriPath() to ensure an absolute
> path is passed in. See minor change to INode#getPathNames, which now asserts
> instead of returning null and causing NPEs. This was exposed via calling
> FileContext#getFileBlockLocations using a symlink.
> * Comment in FSImage around symlinks and image loading
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
