[
https://issues.apache.org/jira/browse/HDFS-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858070#action_12858070
]
Hadoop QA commented on HDFS-1088:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442020/hdfs-1088-4.patch
against trunk revision 934196.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/317/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/317/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/317/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/317/console
This message is automatically generated.
> Prevent renaming a symlink to its target
> -----------------------------------------
>
> Key: HDFS-1088
> URL: https://issues.apache.org/jira/browse/HDFS-1088
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-1088-1.patch, hdfs-1088-2.patch, hdfs-1088-3.patch,
> hdfs-1088-4.patch
>
>
> Here's the HDFS side of HADOOP-6563:
> * Small bug fix for renaming a symlink to it's target
> * Hdfs#getFileBlockLocations needs to use getUriPath() to ensure an absolute
> path is passed in. See minor change to INode#getPathNames, which now asserts
> instead of returning null and causing NPEs. This was exposed via calling
> FileContext#getFileBlockLocations using a symlink.
> * Comment in FSImage around symlinks and image loading
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
