[ 
https://issues.apache.org/jira/browse/HDFS-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863577#action_12863577
 ] 

Todd Lipcon commented on HDFS-1122:
-----------------------------------

20 patch looks good to me. Small nits:

-     assertTrue("/ should be a directory"...) check at the top of  
testPrematureDataBlockScannerAdd seems out of place.
- The javadoc at the top of TestDataBlockScanner is misplaced
- You may also want to add a bit of javadoc to the test case itself that 
explains what it's checking for


> client block verification may result in blocks in DataBlockScanner prematurely
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-1122
>                 URL: https://issues.apache.org/jira/browse/HDFS-1122
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: sam rash
>            Assignee: sam rash
>         Attachments: hdfs-1122-for-0.20.txt
>
>
> found that when the DN uses client verification of a block that is open for 
> writing, it will add it to the DataBlockScanner prematurely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to