[
https://issues.apache.org/jira/browse/HDFS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866274#action_12866274
]
Eli Collins commented on HDFS-1138:
-----------------------------------
Nice catch Dmytro! Patch looks good to me.
* I'd remove the new addChild method and make both callers explicitly pass
whether they propagate the modification time.
* Would update the comment from "update modification time of the parent
directory" to something like "Optionally update the parent's modification time,
we shouldn't if we're just loading an image."
> Modification times are being overwritten when FSImage loads
> -----------------------------------------------------------
>
> Key: HDFS-1138
> URL: https://issues.apache.org/jira/browse/HDFS-1138
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Dmytro Molkov
> Assignee: Dmytro Molkov
> Attachments: HDFS-1138
>
>
> A very easy way to spot the bug is to do a second restart in TestRestartDFS
> and check that the modification time on root is the same as it was before the
> second restart.
> The problem is modifying time of the parent if the modification time of the
> child is greater than parent's in addToParent.
> So if you have /DIR/File then on creation of a file modification time of the
> DIR will be set, but on cluster restart, or when secondary is checkpointing
> and reading the image it will add DIR to "/" and write the new modification
> time for "/" which is the modification time of DIR.
> This is clearly a bug. I will attach a patch with one more parameter being
> passed from the loadFSImage that says to not propagate the time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
