[ 
https://issues.apache.org/jira/browse/HDFS-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867778#action_12867778
 ] 

Todd Lipcon commented on HDFS-1071:
-----------------------------------

Few small notes:

- Please change the Threads to be named - eg "FSImageSaver for /path/to/dir"
- I'm not sure if the behavior under InterruptedException is right - don't we 
want to retry joining on that thread? Or perhaps interrupt those threads 
themselves? I'm worried about leaving a straggling thread saving the namespace 
during a ^C shutdown, for example.
- The code to join on all the threads in the list is repeated a lot - maybe 
factor into a static method?


> savenamespace should write the fsimage to all configured fs.name.dir in 
> parallel
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-1071
>                 URL: https://issues.apache.org/jira/browse/HDFS-1071
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: dhruba borthakur
>            Assignee: Dmytro Molkov
>         Attachments: HDFS-1071.patch
>
>
> If you have a large number of files in HDFS, the fsimage file is very big. 
> When the namenode restarts, it writes a copy of the fsimage to all 
> directories configured in fs.name.dir. This takes a long time, especially if 
> there are many directories in fs.name.dir. Make the NN write the fsimage to 
> all these directories in parallel.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to