[
https://issues.apache.org/jira/browse/HDFS-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870762#action_12870762
]
Konstantin Shvachko commented on HDFS-1161:
-------------------------------------------
# This patch does not apply to current trunk anymore. Eli, could you please
update it.
# There are several "white space" changes in the patch, like
{code}
-
- if(hasEnoughResource) {
+ if (hasEnoughResources) {
{code}
please avoid.
# I see you are changing the name of a public method {{hasEnoughResource()}} to
{{hasEnoughResources()}}. Formally we should go through deprecation process, as
we don't know all dependencies of the method. So if possible please avoid this
too.
# Dhruba, if you have any particular existing config parameter, which can be
used instead of introducing the new one, please speak up.
> Make DN minimum valid volumes configurable
> ------------------------------------------
>
> Key: HDFS-1161
> URL: https://issues.apache.org/jira/browse/HDFS-1161
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-1161-1.patch, hdfs-1161-2.patch, hdfs-1161-3.patch,
> hdfs-1161-4.patch
>
>
> The minimum number of non-faulty volumes to keep the DN active is hard-coded
> to 1. It would be useful to allow users to configure this value so the DN
> can be taken offline when eg half of its disks fail, otherwise it doesn't get
> reported until it's down to it's final disk and suffering degraded
> performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
