[
https://issues.apache.org/jira/browse/HDFS-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876084#action_12876084
]
Todd Lipcon commented on HDFS-1118:
-----------------------------------
Hey Zheng. I was just running into this problem and then remembered that you
put this patch up a while back.
Why not just add an IOUtils.closeSocket() call inside the IOException catch
clause, instead of adding the finally {} clause?
> DFSOutputStream socket leak when cannot connect to DataNode
> -----------------------------------------------------------
>
> Key: HDFS-1118
> URL: https://issues.apache.org/jira/browse/HDFS-1118
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.1, 0.20.2, 0.20-append
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.20-append
>
> Attachments: HDFS-1118.1.patch, HDFS-1118.2.patch
>
>
> The offending code is in {{DFSOutputStream.nextBlockOutputStream}}
> This function retries several times to call {{createBlockOutputStream}}. Each
> time when it fails, it leaves a {{Socket}} object in {{DFSOutputStream.s}}.
> That object is never closed, but overwritten the next time
> {{createBlockOutputStream}} is called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
