[ 
https://issues.apache.org/jira/browse/HDFS-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879864#action_12879864
 ] 

Suresh Srinivas commented on HDFS-1114:
---------------------------------------

# For figuring out 64 bit, should we consider the max heap size. If max heap 
size > 2G consider it as 64 bit machine. Since max heap size on 32 bit machines 
vary, 1.4G to 2G, such machines in that range could be wrongly classified as 32 
bit. Is this an alternative worth considering? 
# Minor: "print detail" to "print detailed"
# Minor: For end of line comments should there be space after //. Java coding 
conventions explicitly do not talk about this though. Currently there 3043 
comments with space after // and 384 without that :-) 
# Minor: In exceptions tests, in my previous comment, what I meant was you are 
better of printing to log in Assert.fail(). Printing log when expected thing 
happens is not that useful. That said, this is minor, you can leave it as it is.
# I am not sure what the point of commenting out 5 hours test is. When do we 
expect it to be uncommented and run? Should it be moved to some other test that 
is run as smoke test for release qualification?


> Reducing NameNode memory usage by an alternate hash table
> ---------------------------------------------------------
>
>                 Key: HDFS-1114
>                 URL: https://issues.apache.org/jira/browse/HDFS-1114
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: GSet20100525.pdf, gset20100608.pdf, 
> h1114_20100607.patch, h1114_20100614b.patch, h1114_20100615.patch, 
> h1114_20100616b.patch, h1114_20100617.patch
>
>
> NameNode uses a java.util.HashMap to store BlockInfo objects.  When there are 
> many blocks in HDFS, this map uses a lot of memory in the NameNode.  We may 
> optimize the memory usage by a light weight hash table implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to