[
https://issues.apache.org/jira/browse/HDFS-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185440#comment-14185440
]
Colin Patrick McCabe commented on HDFS-7282:
--------------------------------------------
I like the patch... we should definitely be closing those
{{TemporarySocketDirectory}} objects.
Sorry if this is a dumb question, but I don't completely understand how you
feel the missing closes are leading to test failures... can you clarify?
> TestShortCircuitCache and TestBlockReaderFactory have failures caused by
> TemporarySocketDirectory getting garbage collected before Datanode starts up
> accessing the dir causing FileNotFoundException.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-7282
> URL: https://issues.apache.org/jira/browse/HDFS-7282
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.4.1
> Reporter: Jinghui Wang
> Assignee: Jinghui Wang
> Attachments: HDFS-7282.patch
>
>
> TemporarySocketDirectory has finalize method deletes the directory, in
> TestShortCircuitCache and TestBlockReaderFactory, the
> TemporarySocketDirectory created are not refereced later in the tests, which
> can get garbage collected (deleted the dir) before Datanode start up
> accessing the directory under TemporarySocketDirectory causing
> FileNotFoundException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
