[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185936#comment-14185936
]
Jing Zhao commented on HDFS-7280:
---------------------------------
The patch looks good to me. Some minor and nits:
# The following code needs some cleanup.
{code}
+ ServerBootstrap b = new ServerBootstrap();
+ b.group(bossGroup, workerGroup)
+ .channel(NioServerSocketChannel.class);
+
+ this.bootstrap = b;new ServerBootstrap();
{code}
# It may be better to catch the InterrupttedException in WebImageViewer#start.
> Use netty 4 in WebImageViewer
> -----------------------------
>
> Key: HDFS-7280
> URL: https://issues.apache.org/jira/browse/HDFS-7280
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
> HDFS-7280.002.patch, HDFS-7280.003.patch
>
>
> This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
