[ 
https://issues.apache.org/jira/browse/HDFS-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188841#comment-14188841
 ] 

Colin Patrick McCabe commented on HDFS-7287:
--------------------------------------------

bq. Here's the patch without the test barfing.

Great!

bq. The build doesn't have any test failures

It has a test timeout, on {{TestPread}}.  However, this is clearly not related 
to your patch.

bq. I'm guessing this is because of the recent changes to test-patch.sh

test-patch.sh wasn't changed recently.  smart-patch-apply.sh was, but that 
shouldn't have anything to do with this test timeout, I think.

bq. Besides this test seems unrelated. Could someone please review and merge?

+1, will commit shortly.

> The OfflineImageViewer (OIV) can output invalid XML depending on the filename
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-7287
>                 URL: https://issues.apache.org/jira/browse/HDFS-7287
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HDFS-7287.1.patch, HDFS-7287.2.patch, HDFS-7287.patch, 
> testXMLOutput
>
>
> If the filename contains a character which is invalid in XML, 
> TextWriterImageVisitor.write() or PBImageXmlWriter.o() prints out the string 
> unescaped. For us this was the character 0x0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to