[
https://issues.apache.org/jira/browse/HDFS-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189193#comment-14189193
]
Konstantin Shvachko commented on HDFS-7263:
-------------------------------------------
I coudn't see the test failures or patch related java warnings locally with or
without the patch.
I have one nit. In the test you added for append you create a new snapshot2.
This is not necessary for this particulare test case.
Could you also add a comment that you are testing snapshot read of a file
opened for append.
> Snapshot read of an appended file returns more bytes than the file length.
> --------------------------------------------------------------------------
>
> Key: HDFS-7263
> URL: https://issues.apache.org/jira/browse/HDFS-7263
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.5.0
> Reporter: Konstantin Shvachko
> Assignee: Tao Luo
> Attachments: HDFS-7263.patch, HDFS-7263.patch, TestSnapshotRead.java
>
>
> The following sequence of steps will produce extra bytes, that should not be
> visible, because they are not in the snapshot.
> * Create a file of size L, where {{L % blockSize != 0}}.
> * Create a snapshot
> * Append bytes to the file
> * Read file in the snapshot (not the current file)
> * You will see the bytes are read beoynd the original file size L
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
