[
https://issues.apache.org/jira/browse/HDFS-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190712#comment-14190712
]
Colin Patrick McCabe commented on HDFS-7199:
--------------------------------------------
The "else" should be on the same line as the close-brace, as per our coding
standard. +1 once that's fixed. Thanks, Rushabh.
> DFSOutputStream can silently drop data if DataStreamer crashes with a non-I/O
> exception
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-7199
> URL: https://issues.apache.org/jira/browse/HDFS-7199
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.5.0
> Reporter: Jason Lowe
> Assignee: Rushabh S Shah
> Priority: Critical
> Attachments: HDFS-7199-WIP.patch, HDFS-7199.patch
>
>
> If the DataStreamer thread encounters a non-I/O exception then it closes the
> output stream but does not set lastException. When the client later calls
> close on the output stream then it will see the stream is already closed with
> lastException == null, mistakently think this is a redundant close call, and
> fail to report any error to the client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
