[ 
https://issues.apache.org/jira/browse/HDFS-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191444#comment-14191444
 ] 

Ravi Prakash commented on HDFS-7309:
------------------------------------

Wow! Thanks Colin! These changes look good to me. I ran the tests on my desktop 
and they both passed so I'm pretty sure Hadoop QA is lying here. I'm a +1 . 
I'll commit these soon if there are no objections.
I think more and more we are implementing StringEscapeUtils though , and it 
might be useful to figure out if we can simply move to commons-lang3 at some 
point. Do you know if there has ever been a discussion about that? I see a 
little bit on HADOOP-10783 but that JIRA has stalled.

> XMLUtils.mangleXmlString doesn't seem to handle less than sign
> --------------------------------------------------------------
>
>                 Key: HDFS-7309
>                 URL: https://issues.apache.org/jira/browse/HDFS-7309
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Ravi Prakash
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-7309.001.patch, HDFS-7309.002.patch, HDFS-7309.patch
>
>
> My expectation was that "<someElement>" + XMLUtils.mangleXmlString(
>       "Containing<ALessThanSign") + "</someElement>" would be a string 
> acceptable to a SAX parser. However this was not true. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to