[
https://issues.apache.org/jira/browse/HDFS-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194807#comment-14194807
]
Jing Zhao commented on HDFS-7147:
---------------------------------
Thanks Nicholas! The patch looks good to me. Only some minor comments:
# Can we use Preconditions.checkNotNull here?
{code}
+ if (policyName == null) {
+ throw new NullPointerException("policyName == " + policyName);
+ }
{code}
# Looks like the current default value is true.
{code}
+ * <<dfs.storage.policy.enabled>>
+ - for enabling/disabling the storage policy feature.
+ The default value is <<<false>>>.
{code}
> Update archival storage user documentation
> ------------------------------------------
>
> Key: HDFS-7147
> URL: https://issues.apache.org/jira/browse/HDFS-7147
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Blocker
> Attachments: h7147_20140926.patch, h7147_20141101.patch
>
>
> The Configurations section is no longer valid. It should be removed.
> Also, if there are new APIs able to get in such as the addStoragePolicy API
> proposed in HDFS-7076, the corresponding user documentation should be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
