[
https://issues.apache.org/jira/browse/HDFS-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201643#comment-14201643
]
stack commented on HDFS-7358:
-----------------------------
A few comments:
+ private volatile boolean isClosed = false;
'isClosed' is name of the method in javabeany-speak. Rename 'closed'
Is 'State' the right name for this inner class that carries
state-of-stream-close and stuff to run on close? CloseState? Or
CloseAndCleanup. Do you need this class? It can't just be a method to call on
close?
Otherwise looks good. I can test the patch later...
> Clients may get stuck waiting when using ByteArrayManager
> ---------------------------------------------------------
>
> Key: HDFS-7358
> URL: https://issues.apache.org/jira/browse/HDFS-7358
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h7358_20141104.patch, h7358_20141104_wait_timeout.patch,
> h7358_20141105.patch, h7358_20141106.patch
>
>
> [~stack] reported that clients might get stuck waiting when using
> ByteArrayManager; see [his
> comments|https://issues.apache.org/jira/browse/HDFS-7276?focusedCommentId=14197036&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14197036].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
