[ 
https://issues.apache.org/jira/browse/HDFS-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated HDFS-7358:
--------------------------------------
    Attachment: h7358_20141107.patch

> Is 'State' the right name for this inner class that carries 
> state-of-stream-close and stuff to run on close? ...  Do you need this class? 
> It can't just be a method to call on close?
 
DFSOutputStream is big and lack of organization.  It has 30+ fields in 
DFSOutputSteam alone, not counting inner classes such as DataStreamer. I think 
it is better separate to group the fields describing the state of the stream 
together.  Since I am not going to move the other fields for the moment, let's 
keep "closed" as a field.  Here is a new patch.

h7358_20141107.patch


> Clients may get stuck waiting when using ByteArrayManager
> ---------------------------------------------------------
>
>                 Key: HDFS-7358
>                 URL: https://issues.apache.org/jira/browse/HDFS-7358
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h7358_20141104.patch, h7358_20141104_wait_timeout.patch, 
> h7358_20141105.patch, h7358_20141106.patch, h7358_20141107.patch
>
>
> [~stack] reported that clients might get stuck waiting when using 
> ByteArrayManager; see [his 
> comments|https://issues.apache.org/jira/browse/HDFS-7276?focusedCommentId=14197036&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14197036].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to