[
https://issues.apache.org/jira/browse/HDFS-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215671#comment-14215671
]
Gera Shegalov commented on HDFS-7398:
-------------------------------------
bq. This version looks great to me. Just one minor nitpick: let's mark
FSEditLogOp#resetSubFields as protected. That will enforce that visibility is
open only for subclasses to implement, and not for other classes within the
same package to call.
Access to {{protected}} is the superset of the package scope according to the
[JLS Section
6.6.1|https://docs.oracle.com/javase/specs/jls/se8/html/jls-6.html#jls-6.6.1].
Not only can you call protected within the package but you can also do it
outside the package in a subclass.
> Reset cached thread-local FSEditLogOp's on every FSEditLog#logEdit
> ------------------------------------------------------------------
>
> Key: HDFS-7398
> URL: https://issues.apache.org/jira/browse/HDFS-7398
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Gera Shegalov
> Assignee: Gera Shegalov
> Attachments: HDFS-7398.v01.patch, HDFS-7398.v02.patch
>
>
> This is a follow-up on HDFS-7385.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
