[jira] [Commented] (HDFS-7312) Update DistCp v1 to optionally not use tmp location

[Yongjun Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215764#comment-14215764
 ] 

Yongjun Zhang commented on HDFS-7312:
-------------------------------------

HI [~jprosser],

Thanks for the new revs. I went through the latest patch (005), it looks good, 
only one minor comment in the test area,

Suggest to create a private method like
{code}
  List<String>  createBaseArgList(final String src, final String dst,
      final boolean skipTmp) {
    List<String> argList = new ArrayList<String>();
    if (skipTmp) {
      argList.add("-skiptmp");
    }
    argList.add(src);
    argList.add(dst);
    return argList;
  }
{code}
So you can use it in several places that do the same thing in the test code you 
created.

BTW, when you load new patch, you don't specify "this patch is for branch-1" 
each time. suggest to edit the jira description to include this info.

Thanks.




> Update DistCp v1 to optionally not use tmp location
> ---------------------------------------------------
>
>                 Key: HDFS-7312
>                 URL: https://issues.apache.org/jira/browse/HDFS-7312
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 2.5.1
>            Reporter: Joseph Prosser
>            Assignee: Joseph Prosser
>            Priority: Minor
>         Attachments: HDFS-7312.001.patch, HDFS-7312.002.patch, 
> HDFS-7312.003.patch, HDFS-7312.004.patch, HDFS-7312.005.patch, HDFS-7312.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> DistCp v1 currently copies files to a tmp location and then renames that to 
> the specified destination.  This can cause performance issues on filesystems 
> such as S3.  A -skiptmp flag will be added to bypass this step and copy 
> directly to the destination.  This feature mirrors a similar one added to 
> HBase ExportSnapshot 
> [HBASE-11119|https://issues.apache.org/jira/browse/HBASE-11119]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)