[
https://issues.apache.org/jira/browse/HDFS-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218310#comment-14218310
]
Charles Lamb commented on HDFS-7390:
------------------------------------
Hi [~benoyantony],
Thanks for working on this -- it's a good improvement.
I'm currently working on HDFS-7331. In
https://issues.apache.org/jira/browse/HDFS-7331?focusedCommentId=14195484&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14195484,
[~wheat9] suggested that I just return the Map directly rather than the
JSON.toString. If I change your code to do that, the output looks like this and
you'd be returning a JSON object, not just a string:
{noformat}
"TieredStorageStats" : "{DISK={capacityTotal=42275598336,
capacityUsed=24576, capacityRemaining=21051469824, blockPoolUsed=24576,
nodesInService=1}}",
{noformat}
Would that work?
If you end up keeping JsonString, I assume you'll use the version from
HADOOP-11308's second patch and not the one in the HDFS-7390 patch. That would
probably happen just by virtue of commit order of the two patches. Also, there
are several lines that are > 80 chars.
> Provide JMX metrics per storage type
> ------------------------------------
>
> Key: HDFS-7390
> URL: https://issues.apache.org/jira/browse/HDFS-7390
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.2
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Attachments: HDFS-7390.patch, HDFS-7390.patch
>
>
> HDFS-2832 added heterogeneous support. In a cluster with different storage
> types, it is useful to have metrics per storage type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
