[ 
https://issues.apache.org/jira/browse/HDFS-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226705#comment-14226705
 ] 

Colin Patrick McCabe commented on HDFS-7023:
--------------------------------------------

bq. Seems that you forget to modify CMake file to add libexpat.

Good catch, I will take a look at that.

bq. I wonder, are there any interests on creating a configuration that does not 
depend on XML parser at all?  What we can do is to create a Options class which 
captures all configuration parameters directly. The XML parser can set the 
configuration parameters accordingly.

Hmm.  Maybe I'm misunderstanding your comment, but I think this is already 
implemented.  The {{Config}} class doesn't depend on the XML parser, in my 
patch... you can create a {{Config}} programmatically and set the values to 
whatever you want.  {{XmlConfigParser}} is just a helper class that just fills 
in a {{Config}} class, by calling the normal setter methods.  If we want to add 
another helper class that fills it in by a different method later, we can.

> use libexpat instead of libxml2 for libhdfs3
> --------------------------------------------
>
>                 Key: HDFS-7023
>                 URL: https://issues.apache.org/jira/browse/HDFS-7023
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7023.001.pnative.patch
>
>
> As commented in HDFS-6994, libxml2 may has some thread safe issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to